From 671afae2c439dda70ec1de7b0e2b4c1dbfc2a1a6 Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Sun, 7 Feb 2021 14:43:27 -0700
Subject: [PATCH] prefer implicitly-defined dtors instead of user dtors with
 empty bodies. (#685)

Not only is this simpler, it avoids clang-tidy complaining about
warning: class * defines a non-default destructor but does not define a copy
constructor, a copy assignment operator, a move constructor or a move
assignment operator [cppcoreguidelines-special-member-functions]
---
 gui/filterdlg.h    | 1 -
 gui/optionsdlg.cc  | 4 ----
 gui/optionsdlg.h   | 2 --
 gui/processwait.cc | 3 ---
 gui/processwait.h  | 1 -
 5 files changed, 11 deletions(-)

diff --git a/gui/filterdlg.h b/gui/filterdlg.h
index ec7069dd7..3ec2e71d3 100644
--- a/gui/filterdlg.h
+++ b/gui/filterdlg.h
@@ -33,7 +33,6 @@ class FilterDialog: public QDialog
   Q_OBJECT
 public:
   FilterDialog(QWidget* parent, AllFiltersData& fd_);
-  ~FilterDialog() {}
 
   void runDialog();
 
diff --git a/gui/optionsdlg.cc b/gui/optionsdlg.cc
index 07e7d30f0..59fabc516 100644
--- a/gui/optionsdlg.cc
+++ b/gui/optionsdlg.cc
@@ -60,10 +60,6 @@ QVariant getOptionValue(QList<FormatOption> opts, int k)
 
 }
 
-//------------------------------------------------------------------------
-FileDlgManager::~FileDlgManager()
-  = default;
-
 //------------------------------------------------------------------------
 void FileDlgManager::buttonClicked()
 {
diff --git a/gui/optionsdlg.h b/gui/optionsdlg.h
index d16638f34..c10d9ac96 100644
--- a/gui/optionsdlg.h
+++ b/gui/optionsdlg.h
@@ -40,8 +40,6 @@ public:
                  QLineEdit* le,
                  QToolButton* tb, bool isInFile);
 
-  ~FileDlgManager();
-
 private:
   QLineEdit* le;
   QToolButton* tb;
diff --git a/gui/processwait.cc b/gui/processwait.cc
index 0de38d911..227591d43 100644
--- a/gui/processwait.cc
+++ b/gui/processwait.cc
@@ -118,9 +118,6 @@ ProcessWaitDialog::ProcessWaitDialog(QWidget* parent, QProcess* process):
 
 }
 
-//------------------------------------------------------------------------
-ProcessWaitDialog::~ProcessWaitDialog()
-= default;
 //------------------------------------------------------------------------
 bool ProcessWaitDialog::getExitedNormally()
 {
diff --git a/gui/processwait.h b/gui/processwait.h
index 1cce33727..37c8559c3 100644
--- a/gui/processwait.h
+++ b/gui/processwait.h
@@ -44,7 +44,6 @@ class ProcessWaitDialog: public QDialog
 public:
   //
   ProcessWaitDialog(QWidget* parent, QProcess* process_);
-  ~ProcessWaitDialog();
 
   bool getExitedNormally();
   int getExitCode();
-- 
2.30.2